Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTTP/3] Increased timeout for a slower test #103410

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

ManickaP
Copy link
Member

While looking at Kusto data before closing #101463, I discovered that this test can take ~30 seconds (based on the logs here: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-103151-merge-c718bf950a8049f997/System.Net.Http.Functional.Tests/3/console.4d14a340.log?helixlogtype=result).
So increasing timeout and removing the helper logs. The reason for deadlock should already be fixed by #102699

Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP
Copy link
Member Author

/ba-g failures unrelated

@ManickaP ManickaP merged commit 1546c4f into dotnet:main Jun 13, 2024
76 of 81 checks passed
@ManickaP ManickaP deleted the http3-timeout branch June 13, 2024 14:50
@karelz karelz added this to the 9.0.0 milestone Jun 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants