-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete -fms-extensions from coreclr native build #102834
Conversation
Tagging subscribers to this area: @hoyosjs |
27819e3
to
b621127
Compare
@@ -204,11 +204,7 @@ EXTERN_C AppDomain* STDCALL GetAppDomain(); | |||
|
|||
inline void RetailBreak() | |||
{ | |||
#ifdef TARGET_X86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why it was defined differently for x86. @jkotas do you have any idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically, inline int 3
gave a better experience under the debugger - the debugger stopped in your code, not inside a Windows DebugBreak
API.
700888f
to
78b29e9
Compare
OSX failure is infra issue (tests are passing but helix job is unable to exit cleanly):
rest of failures are known issues (per Build Analysis). @jkotas, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
For stdcpp conformance, remove the remaining special extensions.
__asm {}
syntax with__asm ("")
src/native
which helped validating the rest of the changes on the platform.