Keep metadata for rooted members in ILLink #102850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
linkable-framework
sbomer
added
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
preserve="fields" only keeps backing fields if a property is already marked. This looks like it depends on the marking order which is unfortunate, but let's keep the existing behavior for now.
jtschuster
approved these changes
May 29, 2024
Comment on lines
+1922
to
+1923
| if (propertyDefinition != null && !Annotations.IsMarked (propertyDefinition)) | ||
| continue; |
There was a problem hiding this comment.
Do we ever need to mark a backing field as visible to reflection since it's reflection over compiler generated code? Could we remove the IsMarked check?
There was a problem hiding this comment.
I like the idea - filed #102856 to track it.
|
Should we also mark members marked by the DebuggerDisplayAttribute as visible to reflection? Not necessarily in this PR. |
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
ILLink wasn't keeping metadata (specifically parameter names) for rooted members, whether rooted as: - part of a root assembly - by a root descriptor XML. - by DebuggerDisplayAttribute/DebuggerTypeProxyAttribute This ensures all of those mark members visible to reflection so that method parameter names are kept.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ILLink wasn't keeping metadata (specifically parameter names) for rooted members, whether rooted as part of a root assembly, or by a descriptor XML.
Fixes #81979