Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some FEATURE_... ifdefs in the GC #103200

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Cleanup some FEATURE_... ifdefs in the GC #103200

merged 1 commit into from
Jun 11, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jun 8, 2024

Fixes #103198

@jkotas jkotas requested a review from MichalStrehovsky as a code owner June 8, 2024 10:19
jkotas
jkotas commented Jun 8, 2024
View reviewed changes
src/coreclr/gc/gc.cpp
// Currently there is no way for us to specific the numa node to allocate on via hosting interfaces to
// a host. This will need to be added later.
#if !defined(FEATURE_CORECLR) && !defined(BUILD_AS_STANDALONE)
if (!CLRMemoryHosted())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that it is ok to delete this last bit of .NET Framework hosting support

@jkotas
Copy link
Member Author

jkotas commented Jun 8, 2024

FEATURE_NATIVEAOT ifdefs in the GC are anti-pattern that causes problems. This is another baby steps towards getting rid of them.

@jkotas jkotas requested review from Maoni0, noahfalk and LakshanF June 8, 2024 10:23
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

LakshanF
LakshanF approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The allocation tick event (Microsoft-Windows-DotNETRuntime/GC/AllocationTick) can now be seen in a native AOT application via PerfView and dotnet-trace.

@jkotas jkotas merged commit c897ce6 into dotnet:main Jun 11, 2024
89 checks passed
@jkotas jkotas deleted the ifdefs branch June 11, 2024 03:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LakshanF LakshanF LakshanF approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@Maoni0 Maoni0 Awaiting requested review from Maoni0

@noahfalk noahfalk Awaiting requested review from noahfalk

Assignees

@jkotas jkotas

Labels
area-GC-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AllocationTick event is missing on NativeAOT
2 participants
@jkotas @LakshanF