ILCompiler: don't strip debug info from 'ilc' during source-build. #103760
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
| @@ -16,6 +16,7 @@ | |||
| <!-- Disable native AOT on FreeBSD when cross building from Linux. --> | |||
| <NativeAotSupported Condition="'$(TargetOS)' == 'freebsd' and '$(CrossBuild)' == 'true'">false</NativeAotSupported> | |||
| <PublishAot Condition="'$(NativeAotSupported)' == 'true'">true</PublishAot> | |||
| <StripSymbols Condition="'$(DotNetBuildSourceOnly)' == 'true' and '$(KeepNativeSymbols)' == 'true'">false</StripSymbols> | |||
There was a problem hiding this comment.
KeepNativeSymbols is initialized as
Lines 393 to 394 in ae6ad88
We could leave out the DotNetBuildSourceOnly condition here, if desired.
There was a problem hiding this comment.
@MichalStrehovsky do you want to keep this as is, or remove the DotNetBuildSourceOnly condition?
There was a problem hiding this comment.
Dropping the '$(DotNetBuildSourceOnly)' == 'true' part sounds good to me.
|
It might be better to add this to https://github.com/dotnet/runtime/blob/main/src/coreclr/tools/aot/AotCompilerCommon.props. I expect we'd need the same for source-built crossgen2 eventually and this file sets shared policies. This project file is getting overhauled in #103375 and if for nothing else, to avoid a conflict. |
@jkotas ptal.
cc @omajid @ViktorHofer