-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set alignment=1 for ELF debug sections #103867
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ElfObjectWriter.cs
Outdated
Show resolved
Hide resolved
…r/ElfObjectWriter.cs Co-authored-by: Filip Navara <filip.navara@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the tests pass
We have a smoke test on dwarfdump. Could we also add some validation for this in the same place? |
dwarfdump does not complain about this detail. We would have to dump the dwarf file, parse the dump and verify that the alignment of debug sections is non-zero. It sounds too complicated to be worth it. It would be better to add validation that linking with |
I agree that a basic app validation would be nice with all four linkers. Since we don't have gold linker installed in the CI, it can be added later. Besides section headers are rarely changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing with all sorts of linkers is a known gap unfortunately and this would be covered if we start doing that.
Fix #103862