[LoongArch64] Part-2:Add runtime assembly code (*.S) files in nativeaot. #104084
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
@shushanhf @huoyaoyuan Could you please review and signoff on this PR? |
| // by the linker (GD->IE/LE relaxation). | ||
| //la.local $a0, \var // | ||
| //ld.d \target, $a0, 0 // | ||
| //.tlsdesccall \var //TODO-LOONGARCH64 |
There was a problem hiding this comment.
Anything preventing fixing this TODO?
There was a problem hiding this comment.
TLSDESC is a new feature on LoongArch that is not yet supported in LLVM, so that .tlsdesccall is not defined yet.
LLVM is expected to support TLS in a few months, and we need to wait for LLVM support before fixing it.
Do I need to delete this TODO?
Thanks!
There was a problem hiding this comment.
It is fine to keep the TODO, but it should explain when it is about. E.g. TODO-LOONGARCH64: Fix once TLSDESC is supported by LLVM (add link to LLVM tracking issue if there is one)
There was a problem hiding this comment.
@sunlijun-610 maybe the LLVM had merged the LA64's TLS patch.
There was a problem hiding this comment.
OK, I will add the note of TODO first.
And I will ask the leader of LoongArch LLVM project. If the LA64's TLS patch has been already merged, I will fix it as soon as possible.
Thanks!
|
@shushanhf Could you please sign-off on this PR? |
OK, thanks. |
src/coreclr/nativeaot/Runtime/unix/unixasmmacrosloongarch64.inc
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/Runtime/unix/unixasmmacrosloongarch64.inc
Outdated
Show resolved
Hide resolved
src/coreclr/nativeaot/Runtime/unix/unixasmmacrosloongarch64.inc
Outdated
Show resolved
Hide resolved
This PR is the second part adding nativeaot support on LoongArch64.
It adds runtime assembly code (*.S) files.