Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete FEATURE_READYTORUN_COMPILER ifdef #104727

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

MichalStrehovsky
Copy link
Member

#103361 resurrected this long-deleted ifdef (it's crossgen1-specific define).

I actually wonder if we should roll back all changes to getHeapClassSize - @EgorBo's #104411 doesn't fix getHeapClassSize to work with valuetypes and we don't have any failing tests, so maybe it doesn't need to handle valuetypes?

#103361 resurrected this long-deleted ifdef (crossgen1-specific code).
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 11, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS
Copy link
Member

I actually wonder if we should roll back all changes to getHeapClassSize - @EgorBo's #104411 doesn't fix getHeapClassSize to work with valuetypes and we don't have any failing tests, so maybe it doesn't need to handle valuetypes?

I think we could, yes, since we're mapping boxed value types to the internal box ref class.

@MichalStrehovsky
Copy link
Member Author

I think we could, yes, since we're mapping boxed value types to the internal box ref class.

I've done that so that we don't need to synchronize this to the managed impl.

@MichalStrehovsky MichalStrehovsky merged commit c09ec65 into main Jul 12, 2024
83 of 89 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch July 12, 2024 07:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants