-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64/Sve: Fix a SVE issue and add CI leg for testing SVE with AltJit #104998
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
/azp run runtime-coreclr jitstress-isas-sve |
No pipelines are associated with this pull request. |
This reverts commit ca23305.
@dotnet/arm64-contrib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the new CI leg!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this is a really really good idea to do - at least we can get some sort of coverage for the time being.
@tannergooding - wondering if there is a way to just run the Sve tests on those legs instead of entire test suite? |
Potentially, but I don't think its worth doing so. As soon as we move to enable Vector to use it by default in .NET 10 we're going to want all code to compile and to do so with SVE instructions being emitted. |
<TestEnvironment Include="jitstressregs4_arm64_sve" JitStressRegs="4" AltJitName="clrjit_universal_arm64_x64.dll" AltJit="*" MaxVectorTBitWidth="128" /> | ||
<TestEnvironment Include="jitstressregs8_arm64_sve" JitStressRegs="8" AltJitName="clrjit_universal_arm64_x64.dll" AltJit="*" MaxVectorTBitWidth="128" /> | ||
|
||
<TestEnvironment Include="jitstress_isas_arm64_sve" AltJitName="clrjit_universal_arm64_x64.dll" AltJit="*" MaxVectorTBitWidth="128" /> <!-- Trigger Sve code paths--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause problems on an Arm64 box where I believe it would be clrjit_universal_arm64_arm64.dll
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing "no" by default since its set to run only on Windows_x64 machines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's right...and that was the reason i did not have on linux/x64 either, otherwise would have to specify libclrjit_universal_arm64_x64.so
/ba-g the specialized test is failing because of timeout |
/azp list |
Address issue recently introduced in #104875 and discussed in #104964 (comment).
Also, added a CI leg to run SVE test with altjit. Discussion: #104964 (comment)