Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64/Sve: Fix a SVE issue and add CI leg for testing SVE with AltJit #104998

Merged
merged 6 commits into from
Jul 17, 2024

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Jul 16, 2024

Address issue recently introduced in #104875 and discussed in #104964 (comment).

Also, added a CI leg to run SVE test with altjit. Discussion: #104964 (comment)

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 16, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@kunalspathak
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-sve

Copy link

No pipelines are associated with this pull request.

@kunalspathak
Copy link
Member Author

@dotnet/arm64-contrib

Copy link
Member

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the new CI leg!

Copy link
Contributor

@TIHan TIHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is a really really good idea to do - at least we can get some sort of coverage for the time being.

@kunalspathak kunalspathak marked this pull request as ready for review July 17, 2024 02:02
@kunalspathak
Copy link
Member Author

@tannergooding - wondering if there is a way to just run the Sve tests on those legs instead of entire test suite?

@tannergooding
Copy link
Member

wondering if there is a way to just run the Sve tests on those legs instead of entire test suite?

Potentially, but I don't think its worth doing so. As soon as we move to enable Vector to use it by default in .NET 10 we're going to want all code to compile and to do so with SVE instructions being emitted.

<TestEnvironment Include="jitstressregs4_arm64_sve" JitStressRegs="4" AltJitName="clrjit_universal_arm64_x64.dll" AltJit="*" MaxVectorTBitWidth="128" />
<TestEnvironment Include="jitstressregs8_arm64_sve" JitStressRegs="8" AltJitName="clrjit_universal_arm64_x64.dll" AltJit="*" MaxVectorTBitWidth="128" />

<TestEnvironment Include="jitstress_isas_arm64_sve" AltJitName="clrjit_universal_arm64_x64.dll" AltJit="*" MaxVectorTBitWidth="128" /> <!-- Trigger Sve code paths-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause problems on an Arm64 box where I believe it would be clrjit_universal_arm64_arm64.dll instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing "no" by default since its set to run only on Windows_x64 machines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right...and that was the reason i did not have on linux/x64 either, otherwise would have to specify libclrjit_universal_arm64_x64.so

@kunalspathak
Copy link
Member Author

/ba-g the specialized test is failing because of timeout

@kunalspathak kunalspathak merged commit 513b503 into dotnet:main Jul 17, 2024
164 of 169 checks passed
@kunalspathak kunalspathak deleted the sve-pipeline branch July 17, 2024 23:33
@kunalspathak
Copy link
Member Author

/azp list

@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants