Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testcase for ILC behavior with preserved generated code #105042

Merged

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jul 17, 2024

The feature setting ensures that ILC sees a constant and has the same warning behavior as ILLink. We decided this is the desired behavior in #85161.

Fixes #85161

The feature setting ensures that ILC sees a constant and has the
same warning behavior as ILLink.
@sbomer sbomer requested a review from MichalStrehovsky July 17, 2024 18:00
@sbomer sbomer requested a review from marek-safar as a code owner July 17, 2024 18:00
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 17, 2024
@dotnet-policy-service dotnet-policy-service bot added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 17, 2024
@sbomer
Copy link
Member Author

sbomer commented Jul 17, 2024

/ba-g "Timeout and deadlettered helix work item. Error messages are not specific to the test so not sure how to file a known issue."

@sbomer sbomer merged commit 8c95a64 into dotnet:main Jul 17, 2024
73 of 76 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
linkable-framework Issues associated with delivering a linker friendly framework needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeAOT difference in behavior to ILLink with descriptor preserved code and constant propagation
2 participants