Remove support for older LLVM versions, and re-order linker flags #105110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have generally tried to support linking multiple versions of LLVM within our git tree. Every new LLVM version moves symbols around between libraries, and as a result, every new version of LLVM requires different linker flags to build. The command line tool `llvm-config` should tell you the exact flags you need, but it is a problem for us when cross-compiling to rely on this, and as a result, we transcribe the result of various llvm-config outputs directly into Mono's CMakeLists.txt. In an effort to support multiple versions of LLVM, flags common between all supported versions were kept in one place, then the version-specific flags appended afterwards. And this has worked fine for years. However: 1. Whilst we only link with `lld`, it is common for contributors and source-build to link with `gold`, `bfd`, or some other GNU-flavoured linker, where library order is essential 2. The list of common libraries to link has remained unchanged for years, but the symbol intra-dependencies may have changed a long time ago, so common symbol order cannot be assumed to remain valid between LLVM versions This has resulted in a long-standing problem for people using e.g. Debian or Ubuntu or GitHub CodeSpaces, rather than always building with one of our dockerfiles representing our "real" build environment, when targeting platforms which use Mono and link LLVM.
|
It looks like the linker order between We need to regenerate the full linker list in |
lewing
approved these changes
Jul 18, 2024
|
Let's run the other azp runs that are most likely affected. Just for peace of mind. |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
requested review from
kg,
akoeplinger,
jkoritzinsky,
jkotas and
steveisok
carlossanlop
approved these changes
Jul 18, 2024
kg
approved these changes
Jul 18, 2024
This was referenced Jul 19, 2024
|
Closing and opening to re-trigger the CI after the outage |
This was referenced Jul 19, 2024
akoeplinger
approved these changes
Jul 19, 2024
This was referenced Jul 23, 2024
* Use ConcurrentDictionary in runtimecounters test Fixes #105443 * Fix build break
…#105530) * Fix issue 98506 - Excessive exceptions generated in StackTraceSymbols * Code review feedback
There was a problem with using heap from the related LoaderAllocator for shuffle thunk cache heap. I have tested it again and it seems that the issue is gone. So I am removing the workaround, making the cache use LoaderAllocator local heap. Close #55697
…rget path in Wasm SDK (#105458)
directhex
requested review from
sbomer,
maraf,
ilonatommy,
pavelsavara,
fanyang-mono,
BrzVlad,
kotlarmilos,
lambdageek,
thaystg and
MichalStrehovsky
as code owners
…-and-fix-linker-order
|
Okay the commit history is a mess, but I updated the linkages to LLVM 19. Ignore the branch name. |
jkoritzinsky
approved these changes
Jul 26, 2024
This was referenced Jul 26, 2024
Build failure: Static graph-based restore failed with exit code .* but did not log an error.
#103526
Open
ilonatommy
approved these changes
Jul 31, 2024
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Aug 2, 2024
akoeplinger
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have generally tried to support linking multiple versions of LLVM within our git tree. Every new LLVM version moves symbols around between libraries, and as a result, every new version of LLVM requires different linker flags to build. The command line tool
llvm-configshould tell you the exact flags you need, but it is a problem for us when cross-compiling to rely on this, and as a result, we transcribe the result of various llvm-config outputs directly into Mono's CMakeLists.txt.In an effort to support multiple versions of LLVM, flags common between all supported versions were kept in one place, then the version-specific flags appended afterwards. And this has worked fine for years. However:
lld, it is common for contributors and source-build to link withgold,bfd, or some other GNU-flavoured linker, where library order is essentialThis has resulted in a long-standing problem for people using e.g. Debian or Ubuntu or GitHub CodeSpaces, rather than always building with one of our dockerfiles representing our "real" build environment, when targeting platforms which use Mono and link LLVM.