-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically export '__managed__Main' when needed #105353
Automatically export '__managed__Main' when needed #105353
Conversation
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Windows.targets
Outdated
Show resolved
Hide resolved
Mmh I think I clearly got something wrong in that CMake list. Not really familiar with it to be honest 😅 |
This is linker complaining it doesn't know where to resolve the references. The test tree builds native components before managed components so there's nothing we can provide. I think the only option is to LoadLibrary/GetProcAddress here like the https://github.com/dotnet/runtime/tree/main/src/tests/nativeaot/SmokeTests/SharedLibrary test is doing. |
ac80c48
to
e3ce06d
Compare
I included those changes but the tests are still failing:
I'm probably missing something obvious, but I'm not really familiar with the test infra here. I could use a hint 😅 |
@jkotas CI is green now 🎉 I think we're a little bit past the RC1 snap, do we need to go through some process to get this into .NET 9? |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug-fix level change.
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview
Follow up to #103504. This PR makes
__managed__Main
be automatically exported as well, and adds a unit test.Note
See #103504 (comment)