Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC cleanup #105517

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

GC cleanup #105517

wants to merge 10 commits into from

Conversation

markples
Copy link
Member

@markples markples commented Jul 25, 2024

  • Rename transfer_regions to transfer_regions_from
  • Include size in dprintf in get_region_info
  • Move decommit dprintf nearer to the relevant code
  • Clarify "regions" vs "region units" in dprintfs
  • [STRESS_]DYNAMIC_HEAP_COUNT -> [STRESS_]DYNAMIC_ADAPTATION_TO_APP
  • Delete a few obsolete comments

Copy link
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@Maoni0 Maoni0 added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 25, 2024
@Maoni0
Copy link
Member

Maoni0 commented Jul 25, 2024

please do not merge. I also have some cleanup stuff that I'll include.

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I actually don't have time to do the cleanup changes I wanted to add due to my OOF. but could you please also add a change that rename the DYNAMIC_HEAP_COUNT define to DYNAMIC_ADAPTATION_TO_APP? since DATAS (and I imagine in the future we'd want to adapt to other things other than size) is not just limited to heap count changes.

@cshung
Copy link
Member

cshung commented Aug 13, 2024

Can we also remove this obsolete comment?

        // REGIONS TODO: we should reserve enough space at the end of what we reserved that's
        // big enough to accommodate if we were to materialize all the GC bookkeeping datastructures.
        // We only need to commit what we use and just need to commit more instead of having to
        // relocate the existing table and then calling copy_brick_card_table.
        // Right now all the non mark array portions are commmitted since I'm calling make_card_table
        // on the whole range. This can be committed as needed.

@markples markples removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants