Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Modify dwarfReg in native llvm-libunwind to be consistent with the LoongArch manual. #106308

Closed
wants to merge 2 commits into from
Closed

[LoongArch64] Modify dwarfReg in native llvm-libunwind to be consistent with the LoongArch manual. #106308

wants to merge 2 commits into from

Conversation

sunlijun-610
Copy link
Contributor

Change the UNW_LOONGARCH of F0-F31 from 32-63 to 64-95.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024
@sunlijun-610
Copy link
Contributor Author

@shushanhf @MichalStrehovsky Could you review this PR?
Thanks!

shushanhf
shushanhf approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

This was referenced Aug 13, 2024
Open
Open
@am11 am11 added area-NativeAOT-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 13, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

This was referenced Aug 13, 2024
Open
Closed
Closed
jkotas
jkotas reviewed Aug 14, 2024
View reviewed changes
src/native/external/llvm-libunwind/include/libunwind.h
UNW_LOONGARCH_F29 = 61,
UNW_LOONGARCH_F30 = 62,
UNW_LOONGARCH_F31 = 63,
UNW_LOONGARCH_F0 = 64,
Copy link
Member

@jkotas jkotas Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is vendored project from https://github.com/llvm/llvm-project/blob/main/libunwind/include/libunwind.h#L1269 . Is this a bug in the upstream project? If yes, could you please make sure that this fix is upstreamed to https://github.com/llvm/llvm-project as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much~!
You are right.
The jit/unwindloongarch64.cpp is too old.

we have to follow the latest la-abi speci https://github.com/loongson/la-abi-specs/blob/release/ladwarf.adoc
And we have to modify this file https://github.com/dotnet/runtime/blob/main/src/coreclr/jit/unwindarm64.cpp#L21

Also thanks @filipnavara

We will close this PR and push a new PR to modify the unwindarm64.cpp.

@sunlijun-610
Copy link
Contributor Author

The new PR for modifying jit/unwindloongarch64.cpp has been submitted to #106382
And this PR can be closed.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@am11 am11 am11 left review comments

@jkotas jkotas jkotas left review comments

@shushanhf shushanhf shushanhf approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
arch-loongarch64 area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunlijun-610 @am11 @jkotas @shushanhf