Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include libz.a in native aot packages #106569

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 17, 2024

Fixes #106566

@jkotas
Copy link
Member Author

jkotas commented Aug 17, 2024

@carlossanlop This would be my fix. It gets rid of the Windows/Unix divergence and centralizes the workaround in a single place in Microsoft.NETCore.Native.Unix.targets

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll trigger some extra azp runs to confirm nothing breaks.
If it all looks good, we will need get it backported to release/9.0.

Copy link

CI/CD Pipelines for this repository:

@dotnet dotnet deleted a comment from azure-pipelines bot Aug 19, 2024
@carlossanlop
Copy link
Member

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

/azp run runtime-community

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@carlossanlop
Copy link
Member

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkotas
Copy link
Member Author

jkotas commented Aug 20, 2024

The failures in outerloop runs are unrelated.

@jkotas jkotas merged commit cee502f into dotnet:main Aug 20, 2024
182 of 199 checks passed
@jkotas jkotas deleted the nativeaot-zlib branch August 20, 2024 00:45
@jkotas
Copy link
Member Author

jkotas commented Aug 20, 2024

/backport to release/9.0-rc1

Copy link
Contributor

Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10463283625

@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native AOT Binaries still depend on libz.so
2 participants