-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include libz.a in native aot packages #106569
Conversation
@carlossanlop This would be my fix. It gets rid of the Windows/Unix divergence and centralizes the workaround in a single place in Microsoft.NETCore.Native.Unix.targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll trigger some extra azp runs to confirm nothing breaks.
If it all looks good, we will need get it backported to release/9.0.
src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets
Show resolved
Hide resolved
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-community |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
The failures in outerloop runs are unrelated. |
/backport to release/9.0-rc1 |
Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10463283625 |
Fixes #106566