[release/9.0] Implement getClassAssemblyName #107516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add getClassAssemblyName * Handle nullptrs * Remove CORINFO_ASSEMBLY_HANDLE * Address feedbacks Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
hez2010
changed the title
jkotas
approved these changes
Sep 9, 2024
|
@hez2010, thank you for implementing AOT support in godbolt! The new dropdown menu is very clean; with separate categories for crossgen2 and AOT when .NET stack is selected. Loving it! 👍 |
jeffschwMSFT
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #106959 (comment), backport #106959 to release/9.0.
/cc: @jkotas
Customer Impact
Codegen inspect tools (like JitDisasmo, godbolt and etc.) using
JitDisasmAssemblieswill fail without this fix.Regression
Testing
Verified using
JitDisasmAssembliesin codegen.Risk
Low. The fix only has impact on debug/checked coreclr debugging where one could use
JitDisasmAssembliesto filter out the jit disasm to print.