[release/9.0] Remove managed EH code frames from stack trace

[github-actions]

Backport of #108723 to release/9.0

/cc @janvorli

Customer Impact

[x] Customer reported
[ ] Found internally

When stack trace is captured using the System.Diagnostics.StackTrace in an exception filter, it contains internal frames of the exception handling implementation that should not be visible to the user as they are an implementation detail.

Here is an example provided by the customer who has reported the problem:

at RyuJitReproduction.Program.TestStackTraceInFilterCallee() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 94
   at System.Runtime.EH.FindFirstPassHandler(Object exception, UInt32 idxStart, StackFrameIterator& frameIter, UInt32& tryRegionIdx, Byte*& pHandler)
   at System.Runtime.EH.DispatchEx(StackFrameIterator& frameIter, ExInfo& exInfo)
   at System.Runtime.EH.RhThrowEx(Object exceptionObj, ExInfo& exInfo)
   at RyuJitReproduction.Program.TestStackTraceInFilterCallee() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 92
   at RyuJitReproduction.Program.TestStackTraceInFilter() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 76
   at RyuJitReproduction.Program.Main() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 70

And this is what it looks like in .NET 8 (and also with this fix):

   at RyuJitReproduction.Program.TestStackTraceInFilterCallee() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 94
   at RyuJitReproduction.Program.TestStackTraceInFilterCallee() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 92
   at RyuJitReproduction.Program.TestStackTraceInFilter() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 76
   at RyuJitReproduction.Program.Main() in C:\Users\Accretion\source\dotnet\RyuJit\RyuJitReproduction\Program.cs:line 70

Regression

[x] Yes
[ ] No

Regression in .NET 9 due to the new exception handling being enabled by default.

Testing

Testing using a repro provided by the customer.

Risk

Low, the change only modifies metadata (adds attributes to the internal EH implementation methods that prevents showing them on the stack trace.

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

[jeffschwMSFT]

lgtm. please get a code review. we will take for consideration in 9 GA

[jeffschwMSFT]

please take a look at the pr failures

[jkotas]

please take a look at the pr failures

This is known intermittent issue with rc1 toolset. We need to update to rc2 to pick up the fix.

[jkotas]

We need to update to rc2 to pick up the fix.

@carlossanlop When do we expect release/9.0 to be updated to rc2 toolset?