Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nativeaot outerloop #108916

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix nativeaot outerloop #108916

merged 1 commit into from
Oct 16, 2024

Conversation

MichalStrehovsky
Copy link
Member

typeof(RegionInfo).Assembly.GetType is too difficult to analyze for trimming. Native AOT outerloop runs crash with a NullReferenceException because the property is not reflection-visible.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

@carlossanlop this test was backported to both .NET 8 and .NET 9 and has been failing in outerloops ever since. We're about to ship .NET 9 GA with 16 out of 20 runtime-nativeaot-outerloop jobs consistently failing. I assume this means they are not part of our shipping criteria. Do you know how would I go about proposing adding runtime-nativeaot-outerloop to the shipping criteria?

Cc @dotnet/ilc-contrib

@MichalStrehovsky
Copy link
Member Author

This doesn't fix all of outerloop because people were being productive writing more trim-unfriendly test code. I'll fix in a follow up in case we need to backport this PR.

@MichalStrehovsky MichalStrehovsky merged commit cc8948a into main Oct 16, 2024
88 of 105 checks passed
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch October 16, 2024 12:35
@MichalStrehovsky
Copy link
Member Author

/backport to release/9.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/11399867413

@MichalStrehovsky
Copy link
Member Author

/backport to release/8.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/11399872244

This was referenced Oct 18, 2024
Merged
Open
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@tarekgh tarekgh Awaiting requested review from tarekgh

Assignees

@MichalStrehovsky MichalStrehovsky

Labels
area-System.Globalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichalStrehovsky @jkotas