FileShare change to ReadWrite

[BaY1251]

No description provided.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

[huoyaoyuan]

This is a behavioral change that doesn't look correct. Zip expects consistency within a file. The same file shouldn't be written simultaneously.

[BaY1251]

@huoyaoyuan Some files, such as log files, are opened by writing throughout the entire lifecycle of the program.The folder containing these files can never be packaged.

[pentp]

You can just create ZipArchiveEntry directly yourself. Using CreateEntryFromFile isn't appropriate in such situations.

[BaY1251]

@pentp I did solve it as you said, but most of the time people don't want to encounter exceptions when using ZipArchive and spend a lot of time looking for temporary solutions

[huoyaoyuan]

but most of the time people don't want to encounter exceptions when using ZipArchive

This is not true. Most of the time people are expecting the methods to be reliable. Reading files that are written by other process requires extra causion and collaboration with the writer. This is not reliable by default.

[BaY1251]

Using compression software such as WinRar, built-in compression in Windows 11, etc., can all be used normally.
Unless debugged under these specific conditions, it will never be found that ZipFile performs differently from mainstream compression software

[ericstj]

Agree with what is said by @huoyaoyuan. Opening a file with write sharing could cause us to write a torn file when we previously would have failed to write at all. Consider in the middle of the call CopyTo a writer writes to both the beginning (missed) and end (observed) of file -- we'd have read a torn version of the file.

You should be able to use other API to perform this action if you can somehow guarantee that other writers to the file will never actually write it, but we should not take this change.

If you'd like to further discuss you can do so in an issue.