Replace DAMT.All with DAMT.AllMethods in delegate creation

[MichalStrehovsky]

DynamicallyAccessedMemberTypes.All can be replaced with the newly added AllMethods since it has the right semantics (keep privates in base types).

Cc @dotnet/illink @eerhardt

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

[eerhardt]

Looks good. Thanks!

Are there any upstream callers that can be changed from All to AllMethods? I’m not sure an easy way to check. It might be nice if the analyzer had an option to alert when you are preserving too much.

[MichalStrehovsky]

Are there any upstream callers that can be changed from All to AllMethods?

I did a search in this repo - we don't use these overloads.

I’m not sure an easy way to check. It might be nice if the analyzer had an option to alert when you are preserving too much.

Yup, would be a nice feature! Cc @dotnet/illink

[MichalStrehovsky]

/ba-g the only not-known-issues are timeouts in unrelated tests