Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build breaks #113179

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Fix build breaks #113179

merged 1 commit into from
Mar 6, 2025

Conversation

MichalStrehovsky
Copy link
Member

Fixes build breaks on less mainstream platforms caused by #111771.

Samples:

Windows x86:

Runtime.WorkstationGC.lib(EHHelpers.cpp.obj)(0,0): error LNK2001: unresolved external symbol _RhpVTableOffsetDispatchAVLocation [D:\a\_work\1\s\src\tests\baseservices\compilerservices\FixedAddressValueType\FixedAddressValueType.csproj]

Riscv:

ld.lld : error : undefined symbol: RhpVTableOffsetDispatchAVLocation [/runtime/src/tests/nativeaot/GenerateUnmanagedEntryPoints/GenerateUnmanagedEntryPoints.csproj] [/runtime/src/tests/build.proj]

@Copilot Copilot bot review requested due to automatic review settings March 5, 2025 23:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/azp list

Copy link

CI/CD Pipelines for this repository:

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@am11 am11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. riscv64 test build gets fixed with this PR.

@am11 am11 mentioned this pull request Mar 6, 2025
@MichalStrehovsky MichalStrehovsky merged commit a015c51 into dotnet:main Mar 6, 2025
149 of 168 checks passed
@MichalStrehovsky MichalStrehovsky deleted the fixbuild branch March 6, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants