Treat Char/Bool as requiring marshalling #113602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #113599 by adjusting the marshalling behavior for char and bool types. It updates the primitive type check in MarshalHelpers.Aot.cs and adds unit tests to verify the correct sizes for char and bool.
- Updated IsStructMarshallingRequired condition to treat bool and char as requiring marshalling.
- Added unit tests verifying that Marshal.SizeOf returns the expected values for char and bool.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/tools/Common/TypeSystem/Interop/IL/MarshalHelpers.Aot.cs | Updated the condition to ensure bool and char are not skipped from marshalling. |
| src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/Marshal/SizeOfTests.cs | Added tests to verify the expected sizes for char and bool marshalling. |
src/coreclr/tools/Common/TypeSystem/Interop/IL/MarshalHelpers.Aot.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
jkotas
reviewed
Mar 17, 2025
src/coreclr/tools/Common/TypeSystem/Interop/IL/MarshalHelpers.Aot.cs
Outdated
Show resolved
Hide resolved
…Aot.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 17, 2025
src/coreclr/tools/Common/TypeSystem/Interop/IL/MarshalHelpers.Aot.cs
Outdated
Show resolved
Hide resolved
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/ba-g unrelated wasm timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #113599