-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete useless tests #113633
Delete useless tests #113633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes a test file that has been deemed unnecessary.
- Removed the entire test file.
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Extracted from #111335. We have a plenty of coverage for this under libraries. |
These two apparently failed a few times in past: https://github.com/search?q=repo:dotnet/runtime+b15307+OR+b04914&type=issues, there are others which have never reported failed since the initial port (e.g. under JitBlue among other places). |
These are among the few tests under src/tests that exercise System.Globalization APIs. They are likely to fail when System.Globalization APIs are broken. We have a plenty of tests that cover System.Globalization APIs under libraries, and we prefer API tests to be under libraries in general. |
I assume that vast majority of tests never failed (in main). It does not mean that it is ok to delete them. The question to ask when deleting tests is whether the coverage is redundant. |
True, but the ones which have reportedly failed slipped though the cracks. Maybe it hasn't happened since the monorepo convergence because of live testing, so they are covered. |
/ba-g unrelated timeouts |
No description provided.