Build src/tests tree in globalization invariant mode #111335
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves 5% in build time (and in size) for Pri1 test builds. Globalization tests live in src/libraries; these are not runtime concerns.
|
Tagging subscribers to this area: @hoyosjs |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I did a pri-1 run with native AOT on Windows locally, but running pri-0 outerloop to cover non-Windows. |
EgorBo
approved these changes
Jan 13, 2025
|
This needs more work and we don't currently need it (I managed to make the tests fit in a ZIP and then not OOM during upload in other ways). |
Extracted to #113633 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves 5% in build time (and in size) for Pri1 test builds. Globalization tests live in src/libraries; these are not runtime concerns.
@dotnet/jit-contrib could someone look at the JIT test changes? Neither of the modified tests look very interesting (I actually wonder if we should just delete both - I don't know what they're testing - the one I'm leaving will succeed even if it prints "Test failed").