Use the regular build scripts for -vs coreclr.sln #114511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with passing the RID in for cDAC and also removes one more direct usage of build-runtime.cmd
ghost
added
the
needs-area-label
jkoritzinsky
removed
the
needs-area-label
|
Tagging subscribers to this area: @hoyosjs |
kunalspathak
approved these changes
Apr 10, 2025
max-charlamb
approved these changes
Apr 11, 2025
|
Does this also resolve #113708? I've been using an old CoreClr.sln for a while because I can't generate a new one. |
|
I tested it locally and it worked for me, so I think so. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with passing the RID in for cDAC and also removes one more direct usage of build-runtime.cmd