[wasm][interp] Add Store intrinsics #114711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lewing
requested review from
BrzVlad,
kotlarmilos,
steveisok and
vitek-karas
as code owners
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/mono/mono/mini/interp/simd-methods.def: Language not supported
Comments suppressed due to low confidence (2)
src/mono/mono/mini/interp/transform-simd.c:1255
- New store intrinsics are introduced with a parameter count check; please ensure that there are corresponding tests validating this behavior.
if (csignature->param_count != 2)
src/libraries/System.Runtime.Intrinsics/tests/Wasm/PackedSimdTests.cs:1
- Consider adding tests for the new store intrinsics to ensure they behave consistently with the rest of the SIMD operations.
// Licensed to the .NET Foundation under one or more agreements.
Contributor
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
steveisok
approved these changes
Apr 15, 2025
Member
Author
|
/ba-g this is not the timeout you are looking for |
This was referenced Apr 16, 2025
Open
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Store aliased intrinsics and add the System.Numerics style SquareRoot to Sqrt