Skip to content

Conversation

am11
Copy link
Member

@am11 am11 commented Apr 29, 2025

This is to fix error seen in #114285

clang-20(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) argument unused during compilation: '--gcc-toolchain=/crossrootfs/x64/usr' [-Wunused-command-line-argument]

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 29, 2025
@am11
Copy link
Member Author

am11 commented Apr 29, 2025

@jkoritzinsky, could you please run extra-platform pipeline against this PR? It was added to fix linux-musl-x64 cross build on linux-x64 host in https://github.com/dotnet/runtime/pull/84870/files, but I think we don't need this argument (--target should be enough). If it fails, then we can limit it to linux-musl or exclude freebsd but lets try this first.

Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky
Copy link
Member

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@am11
Copy link
Member Author

am11 commented Apr 30, 2025

Thanks, linux_musl-x64 leg is green without --gcc-toolchain, e.g.:

before (on main): https://dev.azure.com/dnceng-public/public/_build/results?buildId=1006646&view=logs&j=a5a10ef5-00b4-5192-a5e0-d5614c791e6e&t=49464f9f-dc77-5c1e-eb52-f05912fd00b7

Building native export: "/usr/local/bin/clang-20" -O2 -shared -fpic -D DNNE_ASSEMBLY_NAME=Microsoft.Interop.Tests.NativeExports -D DNNE_COMPILE_AS_SOURCE -I "/__w/1/s/.packages/dnne/2.0.5/tools/platform" -I "/__w/1/s/.packages/microsoft.netcore.app.host.linux-musl-x64/10.0.0-preview.3.25162.19/runtimes/linux-musl-x64/native" -o "/__w/1/s/artifacts/obj/NativeExports/Release/net10.0/linux-musl-x64/dnne/bin/Microsoft.Interop.Tests.NativeExportsNE.so" --target=x86_64-alpine-linux-musl --gcc-toolchain=/crossrootfs/x64/usr --sysroot=/crossrootfs/x64 "/__w/1/s/artifacts/obj/NativeExports/Release/net10.0/linux-musl-x64/dnne/Microsoft.Interop.Tests.NativeExports.g.c" "/__w/1/s/.packages/dnne/2.0.5/tools/platform/platform.c" -lstdc++ "/__w/1/s/.packages/microsoft.netcore.app.host.linux-musl-x64/10.0.0-preview.3.25162.19/runtimes/linux-musl-x64/native/libnethost.a" --target=x86_64-alpine-linux-musl --gcc-toolchain=/crossrootfs/x64/usr --sysroot=/crossrootfs/x64 -fuse-ld=lld -Wl,--rpath-link=/crossrootfs/x64/lib/x86_64-alpine-linux-musl -Wl,--rpath-link=/crossrootfs/x64/usr/lib/x86_64-alpine-linux-musl

after (this PR): https://dev.azure.com/dnceng-public/public/_build/results?buildId=1030263&view=logs&j=a5a10ef5-00b4-5192-a5e0-d5614c791e6e&t=49464f9f-dc77-5c1e-eb52-f05912fd00b7

Building native export: "/usr/local/bin/clang-20" -O2 -shared -fpic -D DNNE_ASSEMBLY_NAME=Microsoft.Interop.Tests.NativeExports -D DNNE_COMPILE_AS_SOURCE -I "/__w/1/s/.packages/dnne/2.0.5/tools/platform" -I "/__w/1/s/artifacts/bin/linux-musl-x64.Release/corehost" -o "/__w/1/s/artifacts/obj/NativeExports/Release/net10.0/linux-musl-x64/dnne/bin/Microsoft.Interop.Tests.NativeExportsNE.so" --target=x86_64-alpine-linux-musl --sysroot=/crossrootfs/x64 "/__w/1/s/artifacts/obj/NativeExports/Release/net10.0/linux-musl-x64/dnne/Microsoft.Interop.Tests.NativeExports.g.c" "/__w/1/s/.packages/dnne/2.0.5/tools/platform/platform.c" -lstdc++ "/__w/1/s/artifacts/bin/linux-musl-x64.Release/corehost/libnethost.a" --target=x86_64-alpine-linux-musl --sysroot=/crossrootfs/x64 -fuse-ld=lld -Wl,--rpath-link=/crossrootfs/x64/lib/x86_64-alpine-linux-musl -Wl,--rpath-link=/crossrootfs/x64/usr/lib/x86_64-alpine-linux-musl

Rest of the failures are unrelated.

@jkoritzinsky
Copy link
Member

/ba-g WBT failures unrelated

@jkotas jkotas merged commit 1949af0 into dotnet:main Apr 30, 2025
187 of 206 checks passed
@am11 am11 deleted the patch-38 branch April 30, 2025 19:27
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants