Fix implementation of IFindReferenceTargetsCallback::FoundTrackerTarget #115921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
jkoritzinsky
added
area-System.Runtime.InteropServices
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/interop-contrib |
AustinWise
reviewed
May 23, 2025
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/ComWrappers.cs
Outdated
Show resolved
Hide resolved
Open
3 tasks
…get to correctly record the found reference paths.
jkoritzinsky
force-pushed
the
mowholder-live-longer
branch
from
00f8f7c to
d4fb6e5
Compare
jkoritzinsky
changed the title
.../System.Private.CoreLib/src/System/Runtime/InteropServices/TrackerObjectManager.NativeAot.cs
Outdated
Show resolved
Hide resolved
|
Maui is crashing because of this, we will need this on Preview 5 |
|
/backport to release/10.0-preview5 |
|
Started backporting to release/10.0-preview5: https://github.com/dotnet/runtime/actions/runs/15279956054 |
4 tasks
.../System.Private.CoreLib/src/System/Runtime/InteropServices/TrackerObjectManager.NativeAot.cs
Outdated
Show resolved
Hide resolved
.../System.Private.CoreLib/src/System/Runtime/InteropServices/TrackerObjectManager.NativeAot.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 27, 2025
|
/backport to release/10.0-preview5 |
|
Started backporting to release/10.0-preview5: https://github.com/dotnet/runtime/actions/runs/15283671298 |
AaronRobinsonMSFT
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115881
The implementation of
FoundTrackerTargetfrom the ComWrappers refactoring incorrectly used the target as the source and compared syncblocks before creating the connection from source to target. As a result, the target object's live was not tied to the source object's lifetime and was released early even though it was still referenced.