Change RhNewString length argument to nint/intptr_t #117552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RhNewString length argument is declared as int, but the asm implementation was using the full 64 bits of the related argument register. That doesn't match the calling convention where there is no guarantee that the upper 32 bits are zeroed. That has caused problem in the interpreter that always loads full registers from the interpreter stack and so sometimes, the upper 32 bits were a garbage and the function failed because the length was seemingly too large.
This change fixes it by changing signature of the RhNewString so that the length is nint in managed code / intptr_t in native code.