Skip to content

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 30, 2025

Depends on dotnet/sdk#50000
Fixes #113628

@pavelsavara pavelsavara added this to the 10.0.0 milestone Jul 30, 2025
@pavelsavara pavelsavara self-assigned this Jul 30, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Jul 30, 2025
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

@akoeplinger please could you merge main when the re-bootstreap happens and merge this if the build is green. I'm out of office till Mon.

Thank you!

@akoeplinger akoeplinger marked this pull request as ready for review August 15, 2025 13:50
@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 13:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables a previously disabled test (HttpStreamingDisabledBy_WasmEnableStreamingResponse_InProject) by removing the ActiveIssue attribute and removing the runtime configuration option that was setting System.Net.Http.WasmEnableStreamingResponse in the browser build targets.

Key changes:

  • Removes the runtime configuration option for System.Net.Http.WasmEnableStreamingResponse from browser build targets
  • Re-enables a test that was previously disabled due to issue #113628

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/mono/browser/build/BrowserWasmApp.targets Removes the RuntimeHostConfigurationOption for System.Net.Http.WasmEnableStreamingResponse
src/libraries/System.Runtime.InteropServices.JavaScript/tests/.../HttpRequestMessageTest.cs Removes ActiveIssue attribute to re-enable the HttpStreamingDisabledBy_WasmEnableStreamingResponse_InProject test

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@akoeplinger
Copy link
Member

/ba-g test failures are unrelated issues

@akoeplinger akoeplinger merged commit 04a02a6 into dotnet:main Aug 15, 2025
91 of 95 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[browser] Test failure in HttpRequestMessageTest.HttpStreamingDisabledBy_WasmEnableStreamingResponse_InProject

2 participants