-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] enable HttpStreamingDisabledBy_WasmEnableStreamingResponse_InProject test #118203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] enable HttpStreamingDisabledBy_WasmEnableStreamingResponse_InProject test #118203
Conversation
Tagging subscribers to 'arch-wasm': @lewing |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
….com/pavelsavara/runtime into browser_http_streaming_response_test
@akoeplinger please could you merge main when the re-bootstreap happens and merge this if the build is green. I'm out of office till Mon. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables a previously disabled test (HttpStreamingDisabledBy_WasmEnableStreamingResponse_InProject
) by removing the ActiveIssue
attribute and removing the runtime configuration option that was setting System.Net.Http.WasmEnableStreamingResponse
in the browser build targets.
Key changes:
- Removes the runtime configuration option for
System.Net.Http.WasmEnableStreamingResponse
from browser build targets - Re-enables a test that was previously disabled due to issue #113628
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/mono/browser/build/BrowserWasmApp.targets |
Removes the RuntimeHostConfigurationOption for System.Net.Http.WasmEnableStreamingResponse |
src/libraries/System.Runtime.InteropServices.JavaScript/tests/.../HttpRequestMessageTest.cs |
Removes ActiveIssue attribute to re-enable the HttpStreamingDisabledBy_WasmEnableStreamingResponse_InProject test |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
/ba-g test failures are unrelated issues |
Depends on dotnet/sdk#50000
Fixes #113628