Skip to content

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jul 30, 2025

make sure that GenerateRuntimeConfigurationFiles would get proper value

Contributes to dotnet/runtime#113628

@pavelsavara pavelsavara requested review from akoeplinger and maraf July 30, 2025 17:35
@pavelsavara pavelsavara self-assigned this Jul 30, 2025
@Copilot Copilot AI review requested due to automatic review settings July 30, 2025 17:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the System.Net.Http.WasmEnableStreamingResponse runtime configuration option to ensure proper value propagation during runtime configuration file generation. This change contributes to addressing runtime issue #113628.

  • Adds a new RuntimeHostConfigurationOption entry for WASM streaming response configuration
  • Follows the established pattern of other HTTP-related configuration options in the same file
Comments suppressed due to low confidence (1)

src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets:623

  • This new runtime configuration option should include corresponding test coverage to verify that the option is properly included when WasmEnableStreamingResponse is set and excluded when it's empty.
    <RuntimeHostConfigurationOption Include="System.Net.Http.WasmEnableStreamingResponse"

@akoeplinger
Copy link
Member

We should probably add a test in https://github.com/dotnet/sdk/blob/70c66f750552cfd28a53d736fe45e373f0db7692/test/TestAssets/TestProjects/KitchenSink/TestApp/TestApp.csproj for

public void It_publishes_the_project_correctly(string targetFramework, string[] expectedPublishFiles)

@pavelsavara pavelsavara merged commit a3a5f93 into dotnet:main Aug 1, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants