-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Remove some uses of dynamic from HardwareIntrinsic test code #118273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some uses of dynamic from HardwareIntrinsic test code #118273
Conversation
This is preventing the AdvSimd tests from running in NativeAOT contexts. Fixes dotnet#118234
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Do the AOT tests get automatically run in the CI ? |
@MichalStrehovsky please run any outerloop pipelines here if necessary |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
You found the right one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see some usages of dynamic
in Helpers.cs
, like in SignExtend<T>()
. We may not be using these helpers in any of the AdvSimd tests, so NativeAOT isn't blocked (yet), but could you please remove these as well while you're here?
If the remaining uses look tedious to fix, we can save them for a follow-up.
I'm working on the follow-up at the moment and I discovered another problem while doing so: #94015 (comment) I'm thinking the best way to keep a correct state is to fix that intrinsic that uses the helper, and then remove |
Ah, I didn't see that. In that case, let's take this as-is. Thanks for the fix! |
There are some nativeaot-outerloop failures on non-arm64 platforms. A bunch of tests are flagged as failing on linux-arm, despite the console logs showing they exited successfully. Some
And on osx-x64,
@MichalStrehovsky do any of these failures look familiar to you? |
This one is known and Build Analysis correctly paired it.
I've not seen this but Helix machines running into OOM is not unusual. Definitely not related to this PR, I'd not block on it. |
/ba-g unrelated OOMs |
This is preventing the AdvSimd tests from running in NativeAOT contexts.
Fixes #118234
@dotnet/arm64-contrib