Skip to content

Conversation

snickolls-arm
Copy link
Contributor

This is preventing the AdvSimd tests from running in NativeAOT contexts.

Fixes #118234

@dotnet/arm64-contrib

This is preventing the AdvSimd tests from running in NativeAOT contexts.

Fixes dotnet#118234
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 1, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

@a74nh
Copy link
Contributor

a74nh commented Aug 1, 2025

Do the AOT tests get automatically run in the CI ?

@EgorBo
Copy link
Member

EgorBo commented Aug 1, 2025

Do the AOT tests get automatically run in the CI ?

cc @MichalStrehovsky

@MichalStrehovsky please run any outerloop pipelines here if necessary

@EgorBo
Copy link
Member

EgorBo commented Aug 1, 2025

/azp run runtime-nativeaot-outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member

@MichalStrehovsky please run any outerloop pipelines here if necessary

You found the right one.

Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see some usages of dynamic in Helpers.cs, like in SignExtend<T>(). We may not be using these helpers in any of the AdvSimd tests, so NativeAOT isn't blocked (yet), but could you please remove these as well while you're here?

If the remaining uses look tedious to fix, we can save them for a follow-up.

@snickolls-arm
Copy link
Contributor Author

I still see some usages of dynamic in Helpers.cs, like in SignExtend<T>(). We may not be using these helpers in any of the AdvSimd tests, so NativeAOT isn't blocked (yet), but could you please remove these as well while you're here?

If the remaining uses look tedious to fix, we can save them for a follow-up.

I'm working on the follow-up at the moment and I discovered another problem while doing so: #94015 (comment)

I'm thinking the best way to keep a correct state is to fix that intrinsic that uses the helper, and then remove dynamic from the helper. As the other way around might involve committing some temporarily incorrect code.

@amanasifkhalid
Copy link
Contributor

I'm working on the follow-up at the moment and I discovered another problem while doing so: #94015 (comment)

Ah, I didn't see that. In that case, let's take this as-is. Thanks for the fix!

@amanasifkhalid amanasifkhalid enabled auto-merge (squash) August 1, 2025 14:51
@amanasifkhalid
Copy link
Contributor

There are some nativeaot-outerloop failures on non-arm64 platforms. A bunch of tests are flagged as failing on linux-arm, despite the console logs showing they exited successfully. Some baseservices/threading tests are failing with OOMs, ex:

17:55:50.857 Running test: baseservices/threading/generics/threadstart/GThread01_threadstart/GThread01_threadstart.dll
System.OutOfMemoryException: Insufficient memory to continue the execution of the program.
   at System.Threading.Thread.StartCore() + 0xd5
   at Gen`1.ThreadPoolTest() + 0xdd
   at Test_thread01.TestEntryPoint() + 0xc3
   at Program.<<Main>$>g__TestExecutor4|0_5(StreamWriter tempLogSw, StreamWriter statsCsvSw, Program.<>c__DisplayClass0_0&) + 0x16f

And on osx-x64, System.Runtime.Numerics.Tests build is failing with the following errors from ILC:

2025-08-01T15:27:58.5531970Z EXEC : error : unexpected line op length at offset 0x00078652 expected 0x2c02 found 0x03 [/Users/runner/work/1/s/src/libraries/System.Runtime.Numerics/tests/System.Runtime.Numerics.Tests.csproj]
2025-08-01T15:27:58.5540700Z EXEC : error : last sequence in debug line table at offset 0x00000000 is not terminated [/Users/runner/work/1/s/src/libraries/System.Runtime.Numerics/tests/System.Runtime.Numerics.Tests.csproj]
2025-08-01T15:27:58.5548600Z EXEC : error : unexpected line op length at offset 0x00078652 expected 0x2c02 found 0x03 [/Users/runner/work/1/s/src/libraries/System.Runtime.Numerics/tests/System.Runtime.Numerics.Tests.csproj]
2025-08-01T15:27:58.5553220Z EXEC : error : last sequence in debug line table at offset 0x00000000 is not terminated [/Users/runner/work/1/s/src/libraries/System.Runtime.Numerics/tests/System.Runtime.Numerics.Tests.csproj]

@MichalStrehovsky do any of these failures look familiar to you?

@MichalStrehovsky
Copy link
Member

And on osx-x64, System.Runtime.Numerics.Tests build is failing with the following errors from ILC:

This one is known and Build Analysis correctly paired it.

Some baseservices/threading tests are failing with OOMs, ex:

I've not seen this but Helix machines running into OOM is not unusual. Definitely not related to this PR, I'd not block on it.

@amanasifkhalid
Copy link
Contributor

/ba-g unrelated OOMs

@amanasifkhalid amanasifkhalid disabled auto-merge August 5, 2025 15:22
@amanasifkhalid amanasifkhalid enabled auto-merge (squash) August 5, 2025 17:46
@amanasifkhalid amanasifkhalid merged commit dfb2850 into dotnet:main Aug 5, 2025
70 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Runtime.Intrinsics community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AdvSimd tests don't run on native AOT

6 participants