[cDAC] implement IXCLRDataMethodInstance::GetName and associated APIs #118966
+371
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements the IXCLRDataMethodInstance::GetName method in the cDAC (contract-based Data Access Component) implementation, replacing a previously unimplemented stub that delegated to the legacy implementation.
Key changes:
- Implements method name generation using
TypeNameBuilder.AppendMethodInternalwith fallback mechanisms - Adds error handling and debug validation against the legacy implementation
- Improves robustness of string retrieval from EE addresses
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ClrDataMethodInstance.cs | Implements GetName method with proper name formatting, fallback logic, and debug validation |
| SOSDacImpl.cs | Removes nested try-catch block in GetMethodTableName method |
| DacStreams_1.cs | Adds exception handling for VirtualReadException in StringFromEEAddress method |
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataMethodInstance.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataMethodInstance.cs
Show resolved
Hide resolved
max-charlamb
force-pushed
the
cdac-methodinstance-getname
branch
from
54a82b9 to
84bc116
Compare
max-charlamb
changed the title
noahfalk
reviewed
Sep 2, 2025
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataFrame.cs
Outdated
Show resolved
Hide resolved
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataStackWalk.cs
Show resolved
Hide resolved
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
rcj1
reviewed
Sep 14, 2025
src/native/managed/cdac/mscordaccore_universal/Legacy/ClrDataMethodInstance.cs
Show resolved
Hide resolved
rcj1
reviewed
Sep 14, 2025
...d/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.cs
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
IXCLRDataStackWalk::GetFrameIXCLRDataFrame::GetMethodInstanceIXCLRDataMethodInstance::GetNameThe former two are required to verify
GetNameas SOS usesIXCLRDataStackWalk::GetFrame->IXCLRDataFrame::GetMethodInstanceto get the instantiation ofIXCLRDataMethodInstance it callsGetName` on.Modifies:
IDacStreams_1.StringFromEEAddressto not throw on read failure. Previously we wrapped this API in a try/catch, given it can return a null value, I believe it is acceptable to return null on read failures.