Skip to content

Conversation

agocke
Copy link
Member

@agocke agocke commented Sep 5, 2025

It looks like there's a small bug in our targets that doesn't allow directly enabling ld_classic through an msbuild property if the XCode version is > 15.

@Copilot Copilot AI review requested due to automatic review settings September 5, 2025 20:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the MSBuild targets that prevented manual enablement of the ld_classic linker when using Xcode versions greater than 15. The fix allows users to explicitly set the UseLdClassicXCodeLinker property to true to force the use of ld_classic regardless of Xcode version.

  • Modifies the condition for adding the -ld_classic linker argument to respect explicit user configuration
  • Maintains backward compatibility by preserving the automatic behavior for Xcode 15

@MichalStrehovsky
Copy link
Member

Should we instead extend the xcode version check? If I understand this correctly, we default to ld_classic on xcode 15 (with an opt out) because that version has problem. We now know xcode 16 also has problems. Should we just default to ld_classic too?

@jkotas jkotas requested a review from filipnavara October 15, 2025 18:58
@agocke
Copy link
Member Author

agocke commented Oct 15, 2025

Should we just default to ld_classic too?

I've taken this advice and included 16 in the version check. I believe 26 actually fixes many of the bugs we're seeing in 16.

@agocke agocke enabled auto-merge (squash) October 15, 2025 21:35
@agocke
Copy link
Member Author

agocke commented Oct 16, 2025

/ba-g dead letter

@agocke agocke merged commit 8f0e8ab into dotnet:main Oct 16, 2025
93 of 95 checks passed
@agocke agocke deleted the fix-ld-classic-flag branch October 16, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants