[release/10.0] Move MLDsa Experimental to appropriate members #119515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
Not experimental: * MLDsaAlgorithm (whole type) * MLDsa (class name) * MLDsa.GenerateKey * MLDsa.ImportMLDsaPublicKey * MLDsa.ImportMLDsaPrivateKey * MLDsa.ImportMLDsaPrivateSeed * MLDsa.ExportMLDsaPublicKey * MLDsa.ExportMLDsaPrivateKey * MLDsa.ExportMLDsaPrivateSeed * MLDsa.SignData * MLDsa.VerifyData * Any *Core method for the above Experimental: * IETF Formats * MLDsa.ImportFromPem * MLDsa.ImportFromEncryptedPem * MLDsa.ImportPkcs8PrivateKey * MLDsa.ImportEncryptedPkcs8PrivateKey * MLDsa.ImportSubjectPublicKeyInfo * MLDsa.ExportPkcs8PrivateKey * MLDsa.ExportPkcs8PrivateKeyPem * MLDsa.ExportEncryptedPkcs8PrivateKey * MLDsa.ExportEncryptedPkcs8PrivateKeyPem * MLDsa.ExportSubjectPublicKeyInfo * MLDsa.ExportSubjectPublicKeyInfoPem * And any *Core methods powering them * Unsure we have the right shape * MLDsa.SignPreHash * MLDsa.VerifyPreHash * MLDsa.SignMu * MLDsa.VerifyMu * And any *Core methods powering them
bartonjs
approved these changes
Sep 10, 2025
PranavSenthilnathan
approved these changes
Sep 10, 2025
|
/ba-g All failures are unrelated, and are now reported. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119289 to release/10.0
/cc @bartonjs
Customer Impact
There are still some areas of concern for the ML-DSA API, but the core scenarios from FIPS 204 are working on both Windows (Insider-Canary) and Linux (OpenSSL 3.5+):
Rather than ship all of
MLDsaunder[Experimental], this change moves it from the type to the members that still have concern (and removes it from ancillary types), to improve user experience.Regression
Testing
A sample was written exercising the core routines described above, and no SYSLIB5006 diagnostics were produced. When referencing one of the IETF format exports, however, the diagnostic returned (as expected)
Risk
Low. Metadata-only.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.