Skip to content

[release/10.0] Move MLDsa Experimental to appropriate members #119515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2025
Merged

[release/10.0] Move MLDsa Experimental to appropriate members #119515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff9d4a1
Move MLDsa Experimental to appropriate members
bartonjs Sep 2, 2025
94e22c3
Missed one
bartonjs Sep 2, 2025
8196c5e
Second ring
bartonjs Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion src/libraries/Common/src/System/Security/Cryptography/MLDsa.cs
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion src/libraries/Common/src/System/Security/Cryptography/MLDsaAlgorithm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.Security.Cryptography
/// Represents a specific algorithm within the ML-DSA family.
/// </summary>
[DebuggerDisplay("{Name,nq}")]
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public sealed class MLDsaAlgorithm : IEquatable<MLDsaAlgorithm>
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion src/libraries/Common/src/System/Security/Cryptography/MLDsaCng.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ namespace System.Security.Cryptography
/// cryptographic libraries.
/// </para>
/// </remarks>
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public sealed partial class MLDsaCng : MLDsa
{
private CngKey _key;
Expand Down
57 changes: 45 additions & 12 deletions src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ public static CngAlgorithm Sha512
/// A new <see cref="CngAlgorithm"/> object that specifies the Module-Lattice-Based Digital Signature
/// Algorithm (ML-DSA).
/// </value>
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public static CngAlgorithm MLDsa => field ??= new CngAlgorithm("ML-DSA"); // BCRYPT_MLDSA_ALGORITHM

/// <summary>
Expand Down
1 change: 0 additions & 1 deletion ...raries/System.Security.Cryptography/src/System/Security/Cryptography/CngAlgorithmGroup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ public static CngAlgorithmGroup Rsa
/// <value>
/// An object that specifies the ML-DSA family of algorithms.
/// </value>
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public static CngAlgorithmGroup MLDsa =>
field ??= new CngAlgorithmGroup("MLDSA"); // NCRYPT_MLDSA_ALGORITHM_GROUP

Expand Down
3 changes: 0 additions & 3 deletions ...braries/System.Security.Cryptography/src/System/Security/Cryptography/CngKeyBlobFormat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ public static CngKeyBlobFormat GenericPublicBlob
/// <remarks>
/// The value identified by this blob format is &quot;PQDSAPUBLICBLOB&quot;.
/// </remarks>
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public static CngKeyBlobFormat PQDsaPublicBlob =>
field ??= new CngKeyBlobFormat("PQDSAPUBLICBLOB"); // BCRYPT_PQDSA_PUBLIC_BLOB

Expand All @@ -160,7 +159,6 @@ public static CngKeyBlobFormat GenericPublicBlob
/// <remarks>
/// The value identified by this blob format is &quot;PQDSAPRIVATEBLOB&quot;.
/// </remarks>
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public static CngKeyBlobFormat PQDsaPrivateBlob =>
field ??= new CngKeyBlobFormat("PQDSAPRIVATEBLOB"); // BCRYPT_PQDSA_PRIVATE_BLOB

Expand All @@ -175,7 +173,6 @@ public static CngKeyBlobFormat GenericPublicBlob
/// <remarks>
/// The value identified by this blob format is &quot;PQDSAPRIVATESEEDBLOB&quot;.
/// </remarks>
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public static CngKeyBlobFormat PQDsaPrivateSeedBlob =>
field ??= new CngKeyBlobFormat("PQDSAPRIVATESEEDBLOB"); // BCRYPT_PQDSA_PRIVATE_SEED_BLOB

Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/MLDsaOpenSsl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ namespace System.Security.Cryptography
/// cryptographic libraries.
/// </para>
/// </remarks>
[Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)]
public sealed partial class MLDsaOpenSsl : MLDsa
{
private SafeEvpPKeyHandle _key;
Expand Down
Loading