[interp] Patch mov_src_off opcodes at emit time so live end offsets are correct #119656
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the interpreter where mov_src_off opcodes were not being properly patched at emit time, causing incorrect live end offsets for garbage collection. The fix ensures GC live range computations work correctly by updating the instruction's opcode and data during emission.
Key changes:
- Patches mov_src_off opcodes with actual move opcodes during emission to fix GC live range calculations
- Adds debug printing improvements to show end offset of method code for easier debugging
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
69 tasks
davidwrighton
approved these changes
Sep 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds debug print of the end offset of method code so it's easier to tell when you've got an invalid offset
Fixes JIT\Regression\JitBlue\Runtime_64208