Skip to content

[interp] Patch mov_src_off opcodes at emit time so live end offsets are correct #119656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2025
Merged

[interp] Patch mov_src_off opcodes at emit time so live end offsets are correct #119656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b155c3
Add diagnostic prints of end of method code
kg Sep 12, 2025
a6bb340
Patch mov_src_off opcodes at emit time so that live end calculations …
kg Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/coreclr/interpreter/compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,12 @@ int32_t* InterpCompiler::EmitCodeIns(int32_t *ip, InterpInst *ins, TArray<Reloc*
*ip++ = srcOffset;
if (opcode == INTOP_MOV_VT)
*ip++ = fSize;

// NOTE: It is important to patch the opcode of the insn so that live end offsets are computed correctly.
// Otherwise the live end offset will be computed using the size of mov_src_off instead of the actual move,
// which will break gc live range computations.
ins->opcode = opcode;
ins->data[0] = fSize;
}
else if (opcode == INTOP_LDLOCA)
{
Expand Down Expand Up @@ -1063,11 +1069,11 @@ class InterpGcSlotAllocator
#endif

ConservativeRange newRange(start, end);

if (m_liveRanges.GetSize() != 0)
{
// Find the first range which has a start offset greater or equal to the new ranges start offset

int32_t hiBound = m_liveRanges.GetSize();
int32_t loBound = 0;
while (loBound < hiBound)
Expand Down Expand Up @@ -7288,14 +7294,16 @@ void InterpCompiler::PrintCompiledCode()
PrintCompiledIns(ip, m_pMethodCode);
ip = InterpNextOp(ip);
}

printf("End of method: %04x: IR_%04x\n", (int32_t)ConvertOffset((int32_t)(ip - m_pMethodCode)), (int32_t)(ip - m_pMethodCode));
}

void InterpCompiler::PrintCompiledIns(const int32_t *ip, const int32_t *start)
{
int32_t opcode = *ip;
int32_t insOffset = (int32_t)(ip - start);

printf("IR_%04x: %-14s", insOffset, InterpOpName(opcode));
printf("%04x: IR_%04x: %-14s", (int32_t)ConvertOffset(insOffset), insOffset, InterpOpName(opcode));
ip++;

if (g_interpOpDVars[opcode] > 0)
Expand Down