-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/9.0] Bump OSX.12 helix queues to OSX.13 #119814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0] Bump OSX.12 helix queues to OSX.13 #119814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates macOS Helix CI queue configurations by upgrading from macOS 12.0 to macOS 13 for both ARM64 and x64 architectures across the runtime testing infrastructure.
Key changes:
- Updates macOS Helix queue versions from OSX.1200 to OSX.13
- Applies changes to both public and internal CI queues
- Affects both ARM64 and x64 macOS platforms
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
eng/pipelines/libraries/helix-queues-setup.yml | Updates macOS queue versions for libraries testing on both ARM64 and x64 |
eng/pipelines/coreclr/templates/helix-queues-setup.yml | Updates macOS queue versions for CoreCLR testing on both ARM64 and x64, covering public and internal projects |
this will need the openssl test disabling from #112647 |
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This is an infra only change |
the osx failure look related |
@vcsjones The quic tests are failing where there is an openssl dependency. I suspect it's not desirable to skip the entire suite outright? |
@ManickaP is this something you know the answer to? |
Note that it's not just QUIC, but also
Is this something known? What are we using for queues in main? Were some fixes done in main? I found #118865, so am I reading it correctly that OpenSSL will never work on Mac anymore? Are we loosing capabilities? Or just test coverage? (Sorry for the barrage of questions, but I don't keep myself up to date with OSX changes). Lastly, backporting #119273 should help. It will use MsQuic with statically linkes OpenSSL for running tests on OSX. |
I'm pretty sure we dropped the openssl dependency on main. I tried integrating #119273, but that unfortunately does not seem like enough. It's still trying to initialize openssl unsuccessfully in the quic tests. I think we are going to need to have it installed on the machines in the 13 queue. |
In main, System.Security completely dropped support for OpenSSL on a Mac. (Explanation later). That happened at #116481, and in #117465, and in #117472.
The whole reason we made this effort to drop OpenSSL on a Mac is that modern macOS with hardened runtimes make this difficult. On recent macOS + Apple Silicon + Hardened Runtime, Apple no longer looks in @bartonjs and I spent a considerable amount of time trying to figure this out in #113399 (comment). tl;dr: getting macOS plus OpenSSL from Homebrew to play nicely on .NET is very difficult which is what lead us to dropping it in the first place. |
This is weird, because on the very same machine, with the same MsQuic package, the tests run on main, eg.:
And console log from this PR https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-119814-merge-fc1956e4f2934e2db4/System.Net.Quic.Functional.Tests/1/console.ba284004.log?helixlogtype=result:
|
In this PR, |
You are right! #117472 changed |
Well, what it means is that QUIC is broken on macOS without OpenSSL, and as time goes on, that gets closer to 100%. (It probably means no one is actually using QUIC on macOS) If you think QUIC is supposed to work there, you should backport the change. If you think it is an "experimental, rough edges, OpenSSL is required" thing, then you could decide turning off the tests is more sensible. Personally, I'd backport the change. |
Note, this is also going to apply to 8.0. I'm just using this one to inform the other bump. I would rather first see if we can get the library installed on the MacOS 13 machines and go from there. |
It kind of is, it's not officially fully supported, but we do not discourage users from it and have a docs how to set it up. Note that this also affects HTTP/3 which is much likely used on OSX than QUIC itself. Either way, we have coverage in 10.0 and main so it's not such a big problem to just disable it. |
No description provided.