-
Notifications
You must be signed in to change notification settings - Fork 5.2k
properly enumerate uninstrumented bounds #119965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the enumeration of memory regions for debug information by properly handling uninstrumented bounds that were introduced in a previous change. The fix ensures that both instrumented and uninstrumented bounds are correctly accounted for when enumerating memory regions, and adds proper alignment padding to prevent partial read failures.
Key Changes:
- Updates memory region enumeration to handle uninstrumented bounds alongside existing instrumented bounds
- Adds alignment padding to prevent NibbleReader from partially failing on unaligned debug info streams
c7bcec4
to
70b2864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/backport to release/10.0 |
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17990332541 |
partial fix for #119921.