[release/10.0] Properly enumerate uninstrumented bounds when stackwalking in minidump w/o heap #120073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
steveisok
changed the title
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
noahfalk
approved these changes
Sep 25, 2025
hoyosjs
approved these changes
Sep 29, 2025
steveisok
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119965 to release/10.0
/cc @steveisok @max-charlamb
Customer Impact
When debugging a mini dump w/o a heap, we fail to properly stackwalk and return with zero frames. The fix updates EnumMemoryRegions to account for uninstrumented bounds and adds padding to end of enumerated DebugInfo stream. The latter change accounts for the nibblereader reading in data in platform pointer sized increments. Previously, if the debuginfo was not aligned the last read would end up partially failing.
Regression
Introduced by #116031 sometime around P5.
Testing
Manual testing of a minidump
Risk
Low
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.