Skip to content

Support dynamically creating tailored continuation layouts #120411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 51 commits into from
Oct 18, 2025
Merged

Support dynamically creating tailored continuation layouts #120411

merged 51 commits into from
Oct 18, 2025

Conversation

@jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Oct 4, 2025

Add ability for the VM to dynamically create continuation layout types and for the JIT to request such types to be created.

@jakobbotsch
Initial
7d27090
@jakobbotsch
Fix build, make tests run
6743534
@jakobbotsch
Tailored continuation layouts
0f8cd9c 
Add ability for the VM to dynamically create continuation layout types
and for the JIT to request such types to be created.
@jakobbotsch
Update type
a642f42
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 4, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Oct 4, 2025

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

jkotas
jkotas reviewed Oct 5, 2025
View reviewed changes
jkotas
jkotas reviewed Oct 5, 2025
View reviewed changes
@jakobbotsch jakobbotsch mentioned this pull request Oct 7, 2025
Merged
jakobbotsch
jakobbotsch commented Oct 7, 2025
View reviewed changes
jkotas
jkotas reviewed Oct 7, 2025
View reviewed changes
jkotas
jkotas reviewed Oct 7, 2025
View reviewed changes
jakobbotsch
jakobbotsch commented Oct 7, 2025
View reviewed changes
@davidwrighton davidwrighton requested a review from noahfalk October 7, 2025 23:22
@jakobbotsch jakobbotsch mentioned this pull request Oct 16, 2025
Merged
jkotas
jkotas reviewed Oct 16, 2025
View reviewed changes
jkotas
jkotas reviewed Oct 16, 2025
View reviewed changes
jkotas
jkotas reviewed Oct 16, 2025
View reviewed changes
noahfalk
noahfalk reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me modulo making RuntimeAsync on by default. If there is a need to get it on by default regardless of the diagnostics I'd suggest we do it in a separate PR.

This was referenced Oct 17, 2025
Open
Open
AndyAyersMS
AndyAyersMS reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIT changes look good.

@build-analysis build-analysis bot mentioned this pull request Oct 17, 2025
Open
@jakobbotsch jakobbotsch mentioned this pull request Oct 17, 2025
Open
@jkotas jkotas mentioned this pull request Oct 18, 2025
Merged
jkotas
jkotas reviewed Oct 18, 2025
View reviewed changes
jkotas
jkotas approved these changes Oct 18, 2025
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

noahfalk
noahfalk approved these changes Oct 18, 2025
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto!

VSadov
VSadov approved these changes Oct 18, 2025
View reviewed changes
Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@jakobbotsch jakobbotsch mentioned this pull request Oct 18, 2025
Open
@jakobbotsch
Copy link
Member Author

jakobbotsch commented Oct 18, 2025

Some numbers for the micro benchmark in #120865 (comment) that measures raw suspension/resumption performance, with 10 million iterations:

Before the change: Took 596.9 ms
After the change: Took 558.0 ms
Async1 for comparison: Took 332.1 ms

@jakobbotsch jakobbotsch merged commit c928a95 into dotnet:main Oct 18, 2025
148 of 150 checks passed
@jakobbotsch jakobbotsch deleted the tailored-continuation-layouts branch October 18, 2025 14:59
@build-analysis build-analysis bot mentioned this pull request Oct 18, 2025
Open
@dotnet-maestro dotnet-maestro bot mentioned this pull request Oct 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky left review comments

@AndyAyersMS AndyAyersMS AndyAyersMS left review comments

@davidwrighton davidwrighton davidwrighton left review comments

Copilot code review Copilot Copilot left review comments

@noahfalk noahfalk noahfalk approved these changes

@jkotas jkotas jkotas approved these changes

@VSadov VSadov VSadov approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jakobbotsch @noahfalk @jkotas @jkoritzinsky @VSadov @AndyAyersMS @davidwrighton