Remove usage of Precode::GetPrecodeFromEntryPoint in WASM.
#120583
+334
−305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @mangod9 |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the usage of Precode::GetPrecodeFromEntryPoint in WebAssembly (WASM) to address compilation issues. The changes restructure code around precode management and code versioning features to make them conditional based on whether portable entrypoints are enabled.
Key changes:
- Conditionally compile precode-related code based on
FEATURE_PORTABLE_ENTRYPOINTS - Wrap code versioning functionality with
FEATURE_CODE_VERSIONINGifdefs - Update build configuration to only enable code versioning when tiered compilation is enabled
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/stubmgr.h | Wraps PrecodeStubManager class definition with FEATURE_PORTABLE_ENTRYPOINTS ifdef |
| src/coreclr/vm/stubmgr.cpp | Conditionally compiles PrecodeStubManager implementation and DAC enumeration |
| src/coreclr/vm/proftoeeinterfaceimpl.cpp | Wraps code versioning related functionality with FEATURE_CODE_VERSIONING ifdefs |
| src/coreclr/vm/prestub.cpp | Adds conditional compilation for precode operations and code versioning features |
| src/coreclr/vm/precode_portable.hpp | Removes GetPrecodeFromEntryPoint method declaration |
| src/coreclr/vm/precode_portable.cpp | Removes GetPrecodeFromEntryPoint method implementation |
| src/coreclr/vm/methodtablebuilder.cpp | Removes a debugging assertion |
| src/coreclr/vm/method.hpp | Conditionally compiles precode and code versioning related methods |
| src/coreclr/vm/method.cpp | Wraps various method implementations with appropriate feature ifdefs |
| src/coreclr/vm/jitinterface.cpp | Conditionally compiles precode-related function entry point logic |
| src/coreclr/vm/interpexec.cpp | Refactors prestub checking logic and fixes formatting |
| src/coreclr/vm/dllimportcallback.h | Improves conditional compilation logic for interpreter features |
| src/coreclr/vm/dllimport.cpp | Adds assertion for unsupported vararg P/Invoke with portable entrypoints |
| src/coreclr/vm/datadescriptor/datadescriptor.inc | Conditionally includes code versioning data descriptors |
| src/coreclr/vm/comdelegate.cpp | Wraps precode-related delegate conversion logic |
| src/coreclr/vm/codeversion.h | Fixes endif comment formatting |
| src/coreclr/vm/ceemain.cpp | Conditionally initializes CodeVersionManager |
| src/coreclr/vm/ceeload.inl | Wraps IL code versioning lookup method |
| src/coreclr/vm/ceeload.h | Conditionally compiles IL code versioning state mapping |
| src/coreclr/vm/ceeload.cpp | Conditionally allocates memory for IL code versioning maps |
| src/coreclr/vm/appdomain.cpp | Conditionally initializes PrecodeStubManager |
| src/coreclr/clrdefinitions.cmake | Moves FEATURE_CODE_VERSIONING definition to tiered compilation section |
jkotas
reviewed
Oct 10, 2025
jkotas
reviewed
Oct 10, 2025
jkotas
reviewed
Oct 10, 2025
jkotas
reviewed
Oct 11, 2025
| pMD->GetTemporaryEntryPoint() && // The prestub may not yet be ready to be used, so force temporary entry point creation, and check again. | ||
| !pMD->IsPointingToPrestub()) | ||
| return; | ||
| // The prestub may not yet be ready to be used, so force temporary entry point creation, and check again. |
There was a problem hiding this comment.
We do a simple IsPointingToPrestub check in other places as DoPrestub skipping optimization, e.g. ReflectionInvocation_CompileMethod. If the correct way to do the prestub skipping is this, we have bugs in the other places.
There was a problem hiding this comment.
I don't fully understand this multi-step process either. @davidwrighton wrote this check originally. I simply didn't care for the complex checks in a predicate so rewrote it.
jkotas
reviewed
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inserted ifdefs and reorganizes things to remove usage of
Precode::GetPrecodeFromEntryPointin WASM.This removes the issue described in #120319