Fix Tensor.Reshape with wildcard #120801
Merged
Fix Tensor.Reshape with wildcard #120801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds support fix for Tensor.Reshape when using a wildcard (-1) by returning the computed newLengths instead of the original lengths, and extends test coverage to include wildcard reshape scenarios for Tensor, TensorSpan, and ReadOnlyTensorSpan, including zero-stride cases.
- Fixes return value in Reshape to use computed inferred dimension array.
- Adds wildcard (-1) reshape tests (including error cases) for Tensor, TensorSpan, and ReadOnlyTensorSpan.
- Extends zero-stride reshape scenario tests with wildcard use.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/libraries/System.Numerics.Tensors/src/System/Numerics/Tensors/netcore/Tensor.cs | Fixes Reshape to return newLengths (wildcard-inferred) instead of original input lengths. |
| src/libraries/System.Numerics.Tensors/tests/TensorTests.cs | Adds wildcard reshape tests and zero-stride reshape with wildcard for Tensor. |
| src/libraries/System.Numerics.Tensors/tests/TensorSpanTests.cs | Adds equivalent wildcard and zero-stride reshape tests for TensorSpan. |
| src/libraries/System.Numerics.Tensors/tests/ReadOnlyTensorSpanTests.cs | Adds equivalent wildcard and zero-stride reshape tests for ReadOnlyTensorSpan. |
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-numerics-tensors |
tannergooding
approved these changes
Oct 16, 2025
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18566317228 |
4 tasks
artl93
pushed a commit
that referenced
this pull request
Oct 17, 2025
Backport of #120801 to release/10.0 /cc @tannergooding @lilinus ## Customer Impact - [x] Customer reported - [ ] Found internally #120343 - Calling `Tensor.Reshape` will fail if using the `-1` wildcard to indicate "remaining". It works as expected for `TensorSpan.Reshape` and `ReadOnlyTensorSpan.Reshape` ## Regression - [ ] Yes - [x] No This is a net new API in .NET 10 ## Testing Explicit tests were added validating the behavior works as expected. ## Risk Low. This is a net new API in .NET 10 and was already working as expected for the other types. --------- Co-authored-by: Linus Hamlin <linus.hamlin@soderbergpartners.se>
|
/ba-g unrelated wasm failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120343.
Also added unit tests for
Tensor.ReshapeforTensorSpanandReadOnlyTensorSpan