[release/10.0] Fix Tensor.Reshape with wildcard #120806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannergooding
approved these changes
Oct 16, 2025
artl93
approved these changes
Oct 16, 2025
tannergooding
added
the
Servicing-consider
artl93
added
Servicing-approved
|
marking approved per approval from Jeff S. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120801 to release/10.0
/cc @tannergooding @lilinus
Customer Impact
#120343 - Calling
Tensor.Reshapewill fail if using the-1wildcard to indicate "remaining". It works as expected forTensorSpan.ReshapeandReadOnlyTensorSpan.ReshapeRegression
This is a net new API in .NET 10
Testing
Explicit tests were added validating the behavior works as expected.
Risk
Low. This is a net new API in .NET 10 and was already working as expected for the other types.