[release/8.0-staging] Simplify findvcvarsall.bat #120914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete unnecessary version check
jkotas
approved these changes
Oct 20, 2025
Member
|
Have we done any testing to validate that .NET 8 works with latest VS? |
Member
This was caught by SDK tests running with the new VS. That covers some set of functionality. Is there a test suite you think would be better? Should we run a net8 servicing CI run for dotnet/runtime on a machine with only new VS? |
Member
|
If this gets covered by a .NET SDK test, it is good enough. I was worried about the scenario being completely broken without us knowing. |
agocke
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #115951 to release/9.0-staging
/cc @agocke @jkotas
Customer Impact
Newer versions of VS don't have the same versioning scheme as expected in these targets, so Native AOT will fail to find the native linker without this change (and will not be usable for targeting the NET 9 TFM).
Regression
Testing
Caught with the SDK tests, fix validated manually.
Risk
Low. Deletion of version check.