Port coreclr interpreter to riscv64 #121276
Conversation
am11
requested review from
filipnavara
and removed request for
MichalStrehovsky
dotnet-policy-service
bot
added
the
community-contribution
|
@jkoritzinsky, this is an initial interpreter port. I wasn't able to run InterpreterTester since src/tests build is broken with |
Co-authored-by: Tomasz Sowiński <tomeksowi@gmail.com>
|
@janvorli, PTAL. Bulk change for the initial port. Testing is currently blocked #115622 (comment), so I couldn’t run tests yet. This is a good checkpoint; follow-up updates will be small and incremental. riscv64 leg is now green, remaining failures are unrelated. |
| add_compile_definitions($<${FEATURE_CORECLR_CACHED_INTERFACE_DISPATCH}:FEATURE_CACHED_INTERFACE_DISPATCH>) | ||
| add_compile_definitions($<${FEATURE_CORECLR_VIRTUAL_STUB_DISPATCH}:FEATURE_VIRTUAL_STUB_DISPATCH>) | ||
|
|
||
| include_directories(${RUNTIME_DIR}) |
There was a problem hiding this comment.
@am11 I assume these added includes are not really needed and they were added for possible future needs to unify it with vm folder includes, right?
I think we don't need to add it to the pal's CMakeLists.txt file.
There was a problem hiding this comment.
They are needed because the inline TLS is now used in src/coreclr/pal/inc/unixasmmacrosriscv64.inc, which is further referenced in debug among other places. I only added it to projects which were failing to build.
3 participants
No description provided.