Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 11, 2025

Backport of #120368 to release/10.0

/cc @MichalStrehovsky @frg2089

Customer Impact

  • Customer reported
  • Found internally

When a .NET project is created in a file path that contains spaces, dotnet publish with PublishAot=true on Windows will fail because we don't quote a command line argument to link.exe

Regression

  • Yes
  • No

The command line argument to link.exe is new as of .NET 10.

Testing

Has been in main for a month already. We quote all the other arguments to link.exe.

Risk

Low, we already quote all the other arguments to link.exe

IMPORTANT: If this backport is for a servicing release, please verify that:

  • For .NET 8 and .NET 9: The PR target branch is release/X.0-staging, not release/X.0.
  • For .NET 10+: The PR target branch is release/X.0 (no -staging suffix).

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@MichalStrehovsky MichalStrehovsky changed the title [release/10.0] Update Microsoft.NETCore.Native.Windows.targets [release/10.0] Fix handling file paths that contain spaces Nov 11, 2025
@agocke agocke added the Servicing-consider Issue for next servicing release review label Nov 11, 2025
@agocke
Copy link
Member

agocke commented Nov 11, 2025

We should have an SDK unit test for this: dotnet/sdk#51655

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@PranavSenthilnathan
Copy link
Member

PranavSenthilnathan commented Nov 14, 2025

Since this PR is targeting release/10.0, this is a reminder that code complete is Monday November 17. If you want the changes in the PR in the release, please merge it on time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-NativeAOT-coreclr Servicing-consider Issue for next servicing release review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants