Arm64: [SVE] Fix failing NaN comparisons in Sve2.ConvertTo* tests

[SwapnilGaikwad]

Contribute towards #121659

This PR fixes the NaN comparisons that were incorrectly handled in ConvertTo* tests as highlighted in the following screenshot.

Failure output.

@dotnet/arm64-contrib @a74nh @EgorBo

[EgorBo]

@SwapnilGaikwad do you need to run runtime-coreclr outerloop?

[SwapnilGaikwad]

runtime-coreclr outerloop

It would be useful, cheers. However, the other Sve2_ShiftArithmeticSaturate* tests would still fail. Up to you if you want to wait until those are fixed.

[EgorBo]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[EgorBo]

@SwapnilGaikwad it looks like this change introduced a lot more new failures from 40-50 to 800+

[SwapnilGaikwad]

@SwapnilGaikwad it looks like this change introduced a lot more new failures from 40-50 to 800+

Apologies. Now limited the changes to only ConvertTo* tests using separate templates. Let's see how this goes, didn't show any failures locally.

[SwapnilGaikwad]

Hi @EgorBo, should we run runtime-coreclr outerloop tests on this?

[EgorBo]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dotnet-policy-service]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

[SwapnilGaikwad]

Seems majority of the failures are related to ShiftArithmeticSaturate that are tracked in #121659

[a74nh]

/azp run runtime-coreclr outerloop

I though that the changes made here for eng/pipelines/coreclr/hardware-intrinsics.yml meant that the hardware instrinsic tests would all automatically be run for any PR that touches eng/pipelines/**, src/coreclr/jit/**, src/tests/Common/GenerateHWIntrinsicTests/**, src/tests/JIT/HardwareIntrinsics/**

[EgorBo]

/azp run runtime-coreclr outerloop

I though that the changes made here for eng/pipelines/coreclr/hardware-intrinsics.yml meant that the hardware instrinsic tests would all automatically be run for any PR that touches eng/pipelines/**, src/coreclr/jit/**, src/tests/Common/GenerateHWIntrinsicTests/**, src/tests/JIT/HardwareIntrinsics/**

@jkoritzinsky @dotnet/jit-contrib any YML experts?

[a74nh]

Ok, so we're seeing failures from the other issues here. Although the CI run has been cleared up now, so difficult to be sure. Should we merge this as it is? OR do we need to wait for the others to be fixed - as long as we don't end up where everything is waiting for everything else to be merged first :)

[jkoritzinsky]

Someone disabled the hardwareintrinsics pipeline on Azure DevOps, so that's why it hasn't triggered.

https://dev.azure.com/dnceng-public/public/_build?definitionId=325&_a=summary&view=runs

I'm reaching out to see why it's disabled.

[jkoritzinsky]

Looks like there was a step missed in the pipeline setup. Reached out to the people who have permissions to fix the problem.

[jkoritzinsky]

Pipeline should be fixed now.

[EgorBo]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[a74nh]

• runtime-coreclr outerloop (Build linux-arm64 checked)

I'm a little confused about the CI - looks like lots of tests were cancelled?

The failures seem to be CI issues - "Helix API does not contain an entry for $(helix_macos_arm64)"

[jakobbotsch]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jakobbotsch]

The failures seem to be CI issues - "Helix API does not contain an entry for $(helix_macos_arm64)"

This one was #122061, it should have been fixed. Now there is another outerloop problem that I opened #122295 for.

[a74nh]

The failures seem to be CI issues - "Helix API does not contain an entry for $(helix_macos_arm64)"

This one was #122061, it should have been fixed. Now there is another outerloop problem that I opened #122295 for.

Ok, everything in CI here looks ok other than that.
And this PR is only touching hwintrinsic tests on Arm64.
Is this PR ok to merge then?

[AndyAyersMS]

Going to merge this one as at least some of the arm64 outerloop hw intrisic legs passed.

[jakobbotsch]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jakobbotsch]

/ba-g #122345 and an infra restore issue "D:\a_work\1\s.dotnet\sdk\10.0.100\NuGet.RestoreEx.targets(19,5): error : Invalid restore input. No target frameworks specified". hardware-intrinsics issue was #122061.