-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Enable PlatformNativeR2R test on macOS #121752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to 'os-ios': @vitek-karas, @kotlarmilos, @steveisok, @akoeplinger |
|
Will it be exercised with |
|
It should actually be part of the regular run (and actually test R2R since it has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables the PlatformNativeR2R test on macOS by adding support for Mach-O output format in crossgen2 compilation. The changes introduce a CrossGen2OutputFormat property that can be passed to crossgen2, update the test generation scripts to handle Mach-O object files and link them into dynamic libraries, and enable the previously disabled test on macOS and Apple mobile platforms.
Key Changes:
- Added
CrossGen2OutputFormatproperty support in test project configuration - Updated bash script generation to handle Mach-O format output, including linking
.ofiles into.dyliblibraries - Enabled
PlatformNativeR2Rtest for Windows, macOS, and Apple mobile platforms (previously Windows-only)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/tests/Loader/PlatformNativeR2R/PlatformNativeR2R.csproj |
Removes Windows-only restriction, updates platform condition to include macOS/Apple targets, and sets CrossGen2OutputFormat to macho |
src/tests/Loader/PlatformNativeR2R/PlatformNativeR2R.cs |
Enables previously commented-out assertion for READYTORUN_FLAG_PlatformNativeImage |
src/tests/Common/CLRTest.CrossGen.targets |
Adds support for CrossGen2OutputFormat parameter, implements Mach-O linking logic with clang, updates file extension handling for composite builds, and cleans up composite-r2r files with wildcard pattern |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AaronRobinsonMSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💩
Crossgen2OutputFormatin tests - passed as-f <format>to crossgen2PlatformNativeR2Rtest on macOS and set format tomachocc @dotnet/appmodel @AaronRobinsonMSFT